Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core)!: Update hasTracingEnabled to consider empty trace config #14857

Merged
merged 5 commits into from
Dec 30, 2024
Merged

feat(core)!: Update hasTracingEnabled to consider empty trace config #14857

merged 5 commits into from
Dec 30, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 30, 2024

This PR updates the behavior of passing undefined to tracesSampleRate (or enabledTracing). now, this will not trigger TWP, but tracing will be disabled. If you really want TWP, you need to configure tracesSampleRate: 0.

Closes #13262

@mydea mydea requested review from Lms24, AbhiPrasad and s1gr1d December 30, 2024 13:27
@mydea mydea self-assigned this Dec 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.89 KB -0.45% -104 B 🔽
@sentry/browser - with treeshaking flags 21.63 KB -0.4% -87 B 🔽
@sentry/browser (incl. Tracing) 35.47 KB -0.19% -67 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.73 KB -0.1% -73 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.15 KB -0.14% -85 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 77.14 KB -0.09% -69 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.51 KB -0.1% -91 B 🔽
@sentry/browser (incl. Feedback) 39.66 KB -0.28% -112 B 🔽
@sentry/browser (incl. sendFeedback) 27.54 KB -0.29% -82 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.3 KB -0.26% -86 B 🔽
@sentry/react 25.67 KB -0.3% -79 B 🔽
@sentry/react (incl. Tracing) 38.29 KB -0.18% -67 B 🔽
@sentry/vue 27.17 KB -0.32% -88 B 🔽
@sentry/vue (incl. Tracing) 37.33 KB -0.23% -85 B 🔽
@sentry/svelte 23.08 KB -0.37% -87 B 🔽
CDN Bundle 24.27 KB -0.38% -94 B 🔽
CDN Bundle (incl. Tracing) 35.82 KB -0.25% -89 B 🔽
CDN Bundle (incl. Tracing, Replay) 70.91 KB -0.14% -97 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 76.1 KB -0.12% -89 B 🔽
CDN Bundle - uncompressed 71.18 KB -0.33% -241 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 106.65 KB -0.23% -241 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.71 KB -0.11% -241 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.58 KB -0.11% -241 B 🔽
@sentry/nextjs (client) 38.59 KB -0.19% -75 B 🔽
@sentry/sveltekit (client) 36 KB -0.22% -79 B 🔽
@sentry/node 162.04 KB -0.07% -109 B 🔽
@sentry/node - without tracing 98.77 KB -0.13% -126 B 🔽
@sentry/aws-serverless 128.61 KB -0.09% -110 B 🔽

View base workflow run

@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
692 3 689 297
View the top 3 failed tests by shortest run time 
pinia.test.ts sends pinia action breadcrumbs and state context
Stack Traces | 30s run time 
pinia.test.ts:4:1 sends pinia action breadcrumbs and state context
errors.test.ts sends an error
Stack Traces | 30s run time 
errors.test.ts:4:1 sends an error
errors.test.ts sends an error with a parameterized transaction name
Stack Traces | 30s run time 
errors.test.ts:32:1 sends an error with a parameterized transaction name

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@mydea mydea force-pushed the fn/hasTracingEnabled-undefined branch from f25a9cf to 2188e1a Compare December 30, 2024 14:26
s1gr1d
s1gr1d reviewed Dec 30, 2024
View reviewed changes
packages/browser/src/sdk.ts Outdated Show resolved Hide resolved
@mydea mydea merged commit e0785ea into develop Dec 30, 2024
151 checks passed
@mydea mydea deleted the fn/hasTracingEnabled-undefined branch December 30, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1gr1d s1gr1d s1gr1d left review comments

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v9] Passing undefined to SDK init options should behave like not setting the options
3 participants
@mydea @AbhiPrasad @s1gr1d